x/build/cmd/relnote: RELNOTE in Gerrit comments are missed after Gerrit UI change in July 2020 #41849
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
release-blocker
Milestone
Comments
dmitshur
added
Builders
|
Change https://golang.org/cl/260337 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Oct 7, 2020
Also add a few more TODOs as found by the relnote command. It's an incomplete list due to #41849. For #40700. Change-Id: Id17a9be86d3338e1fcb281d26e7298ff26e92864 Reviewed-on: https://go-review.googlesource.com/c/go/+/260337 Reviewed-by: Ian Lance Taylor <iant@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org>
|
Change https://golang.org/cl/272906 mentions this issue: |
|
Change https://golang.org/cl/272907 mentions this issue: |
|
Change https://golang.org/cl/272871 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Nov 24, 2020
The additions were generated using golang.org/x/build/cmd/relnote at CL 272907. It was modified to find previously-missed entries by querying the Gerrit API in addition to the maintner corpus. For #40700. Updates #41849. Change-Id: If575984fe40e0133ad5e8fc5411ea5063457250d Reviewed-on: https://go-review.googlesource.com/c/go/+/272871 Trust: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
|
Sent CL 272907. I went with the following approach:
If maintner is modified in the future to track inline comments in the future, |
dmitshur
added
NeedsFix
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Dec 1, 2020
Apply a trivial code simplification. Tested by re-running relnote, and its output did not change. For golang/go#41849. Change-Id: Ifffebca5ee55d7470f32a2469b4e41d1a1a458d1 Reviewed-on: https://go-review.googlesource.com/c/build/+/272906 Trust: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
Similarly to #40106, another effect of the Gerrit UI switch from change messages to patchset comments is that that when "RELNOTE=yes" is posted in a comment (rather than in the commit message), it is not picked up by the
relnotecommand today.For example, CL 258957 has a comment that contains "RELNOTES=yes", yet it's not picked up by
relnote.Unlike #40106,
relnoteuses maintner to very quickly scan over all CLs covering a time period of 6 months rather than the Gerrit API, so the fix is not going to be as straightforward. There are different paths that come to mind:Support for inline comments can be added to the maintner data model. This is already tracked in x/build/maintner: GerritMessage doesn't include inline comments #24863. (It may have a significant effect on the amount of data being recorded, but measurements haven't been done yet. Also see x/build/maintner/maintnerd, x/build/maintner: changes are hard to review and test #37603.)
Another option is to modify
relnoteto use the Gerrit API. It should be possible to write a search query to find the relevant CLs. If such a search query is possible, this might be a much smaller volume of work.Find an effective replacement for the
x/build/cmd/relnotecommand and delete it./cc @cagedmantis @toothrot
The text was updated successfully, but these errors were encountered: