Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/godoc: support automatic vendoring #35429

Closed
dmitshur opened this issue Nov 7, 2019 · 1 comment
Closed

x/tools/cmd/godoc: support automatic vendoring #35429

dmitshur opened this issue Nov 7, 2019 · 1 comment
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository. Vendoring
Milestone
Go1.15

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Nov 7, 2019

Quoting @bcmills from #33655 (comment):

[godoc] doesn't play nicely with automatic vendoring in 1.14 (#33848):

~/go/src/cmd$ go version
go version devel +abec5d0879 Wed Nov 6 16:49:40 2019 -0500 linux/amd64

~/go/src/cmd$ go version $(which godoc)
/usr/local/google/home/bcmills/bin/godoc: devel +abec5d0879 Wed Nov 6 16:49:40 2019 -0500

~/go/src/cmd$ godoc
using module mode; GOMOD=/usr/local/google/home/bcmills/go/src/cmd/go.mod
failed to determine the build list of the main module: go command exited unsuccessfully: exit status 1
go list -m: can't compute 'all' using the vendor directory
        (Use -mod=mod or -mod=readonly to bypass.)

I left a few comments on CL 196983 suggesting the points in the implementation that might need to be adapted for vendoring.

godoc needs to be updated so that it continues to work with Go 1.14 (instead of always returning an error in module mode) and so that it displays documentation consistent with what go build would use.
@dmitshur dmitshur added Vendoring NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. modules Tools This label describes issues relating to any tools in the x/tools repository. labels Nov 7, 2019
@dmitshur dmitshur added this to the Go1.14 milestone Nov 7, 2019
@dmitshur dmitshur mentioned this issue Nov 7, 2019
Closed
@dmitshur dmitshur self-assigned this Nov 8, 2019
@dmitshur dmitshur mentioned this issue Nov 21, 2019
Closed
@toothrot toothrot modified the milestones: Go1.14, Go1.15 Feb 25, 2020
@toothrot toothrot changed the title x/tools/cmd/godoc: support automatic vendoring in Go 1.14 x/tools/cmd/godoc: support automatic vendoring Feb 25, 2020
petems added a commit to petems/go-sshconfig that referenced this issue Mar 15, 2020
@petems
Adding go test examples for godoc
67ee4e7 
* Can’t see locally until golang/go#35429 is fixed :(
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/232958 mentions this issue: cmd/godoc: support automatic vendoring

@dmitshur dmitshur mentioned this issue Mar 19, 2021
Closed
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 19, 2021
@golang golang locked and limited conversation to collaborators Mar 19, 2022
apstndb pushed a commit to apstndb/gotoolsdiff that referenced this issue Jan 11, 2025
@agnivade
cmd/godoc: support automatic vendoring
cd3927d 
Fixes golang/go#35429

Change-Id: I060ccfbed4c3975d1ddc94fda4fadea527b29841
Reviewed-on: https://go-review.googlesource.com/c/tools/+/232958
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository. Vendoring
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot