This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
SafeWriter.Write noExamples->examples #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, good call. As a rule, the negation in the variable always makes it harder to reason about, as the reader's mind has to perform e.g. a double negation instead of one. |
sdboyer
approved these changes
Jun 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#672
This PR proposes inverting a bool method parameter:
I see that using a negative makes sense for the command line flag (
no-examples), but I don't see a compelling reason to propagate that into the library code where it seems unidiomatic and a default/zero value is not relevant.