Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite3: fix wrong schema table usage #166

Merged
merged 1 commit into from
Feb 2, 2019
Merged

sqlite3: fix wrong schema table usage #166

merged 1 commit into from
Feb 2, 2019

Conversation

bcho
Copy link
Contributor

@bcho bcho commented Feb 1, 2019

fixes: #165

@coveralls
Copy link

coveralls commented Feb 1, 2019

Pull Request Test Coverage Report for Build 294

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.188%

Totals Coverage Status
Change from base Build 285: 0.0%
Covered Lines: 773
Relevant Lines: 1306

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 1, 2019

Pull Request Test Coverage Report for Build 295

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.188%

Totals Coverage Status
Change from base Build 285: 0.0%
Covered Lines: 773
Relevant Lines: 1306

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bcho
Copy link
Contributor Author

bcho commented Feb 2, 2019 via email

@bcho
Copy link
Contributor Author

bcho commented Feb 2, 2019

@dhui test updated, PTAL

@dhui dhui merged commit 598addc into golang-migrate:master Feb 2, 2019
@bcho bcho deleted the fix/sqlite3-migration-table branch February 3, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong migration table usage in sqlite3.ensureVersionTable
3 participants