Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added mongodb driver #146

Merged
merged 8 commits into from
Jan 8, 2019
Merged

added mongodb driver #146

merged 8 commits into from
Jan 8, 2019

Conversation

bobrovde
Copy link
Contributor

@bobrovde bobrovde commented Jan 1, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jan 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 260

  • 97 of 133 (72.93%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 59.188%
Changes Missing Coverage Covered Lines Changed/Added Lines %
database/mongodb/mongodb.go 97 133 72.93%
Totals Coverage Status
Change from base Build 259: 1.6%
Covered Lines: 773
Relevant Lines: 1306
💛 - Coveralls

dhui
dhui requested changes Jan 2, 2019
View reviewed changes
Copy link
Member

@dhui dhui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

You'll need to use dep to pin the mongodb driver dependency for Go 1.10.x CI tests to pass.

- Add dependency for dep
309edb6 
- Add transaction mode for migrations
dhui
dhui requested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback!

dhui
dhui requested changes Jan 5, 2019
View reviewed changes
dhui
dhui requested changes Jan 7, 2019
View reviewed changes
dhui
dhui requested changes Jan 7, 2019
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this approach is much cleaner!

dhui
dhui approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once TravisCI is working again and tests pass, I'll merge this in.
Thanks again @bobrovde for your contribution and for addressing all of the feedback!

@bobrovde
Copy link
Contributor Author

bobrovde commented Jan 8, 2019

Thanks for your review and time!

@dhui dhui merged commit b1a199a into golang-migrate:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhui dhui dhui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bobrovde @coveralls @dhui