Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use URL.Opaque when available #143

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Conversation

coolaj86
Copy link
Contributor

This change will cause all of the following to be handled correctly:

file:relpath/to/thing
file:/abspath/to/thing
file://relpath/to/thing
file:///abspath/to/thing

The parsed URL with have either u.Opaque or u.Path, never both.

A URL represents a parsed URL (technically, a URI reference).

The general form represented is:

[scheme:][//[userinfo@]host][/]path[?query][#fragment]

URLs that do not start with a slash after the scheme are interpreted as:

scheme:opaque[?query][#fragment]

@coveralls
Copy link

Pull Request Test Coverage Report for Build 242

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.728%

Totals Coverage Status
Change from base Build 240: 0.0%
Covered Lines: 676
Relevant Lines: 1171

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 242

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.728%

Totals Coverage Status
Change from base Build 240: 0.0%
Covered Lines: 676
Relevant Lines: 1171

💛 - Coveralls

@dhui
Copy link
Member

dhui commented Dec 21, 2018

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants