Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring help overlay page and increasing tests coverage +5% #18

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

gokulk16
Copy link
Owner

Changes:

  • Refactored the help page actions to a new file
  • Added tests for the contents of the new file
  • Removed the localize file since not used for now

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for typetocalculate ready!

Name Link
🔨 Latest commit 0a46e0e
🔍 Latest deploy log https://app.netlify.com/sites/typetocalculate/deploys/6666e78462dd9d0008343d12
😎 Deploy Preview https://deploy-preview-18--typetocalculate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.82%
⬆️ +5.89%
462 / 966
🔵 Statements 47.82%
⬆️ +5.89%
462 / 966
🔵 Functions 44.64%
⬆️ +4.29%
25 / 56
🔵 Branches 74.68%
⬆️ +3.85%
59 / 79
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
js/editor.js 38.6% 85.71% 36.36% 38.6% 32, 35-36, 42-48, 50-53, 56-73, 75-78, 80-84, 114-117, 123-124, 183-203, 221-237, 239-241, 243-252, 254-294, 296-315, 317-324, 327-357, 359-374, 376-385, 409-411, 413-421, 423-426, 429-432, 434-473, 479-481, 483-485, 488-518, 539-540, 564-573, 575-579, 596-638, 640-642, 644-668, 682-683, 686-701, 704-715
js/help_page.js 100% 100% 100% 100%
Generated in workflow #13

@gokulk16 gokulk16 merged commit 97ed1bc into main Jun 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant