fixing PR review comments

gokulk16 · Sep 22, 2024 · 9832c17 · 9832c17
1 parent 922810d
commit 9832c17
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 18 deletions.
diff --git a/esbuild-helper/copy-file-plugin.js b/esbuild-helper/copy-file-plugin.js
@@ -1,11 +1,11 @@
 import fs from "fs";
 
-const copyFilePlugin = (fileSrcPath, fileDestPAth) => ({
+const copyFilePlugin = (fileSrcPath, fileDestPath) => ({
   name: "copy-file-plugin",
   setup(build) {
     build.onEnd(async () => {
       try {
-        fs.copyFileSync(fileSrcPath, fileDestPAth);
+        fs.copyFileSync(fileSrcPath, fileDestPath);
       } catch (e) {
         console.error(`Failed to copy file: ${fileSrcPath}`, e);
       }

diff --git a/html/index.html b/html/index.html
@@ -15,6 +15,7 @@
       href="./assets/images/favicon/favicon-48.png"
     />
     <link rel="manifest" href="manifest.json">
+    <script src="https://cdn.jsdelivr.net/npm/pwacompat/pwacompat.min.js" integrity="sha256-QmifG9ty2co3761lBWJwL5KdDOdJ4sFjQ/ULE4aD18U=" crossorigin="anonymous"></script>
   </head>
   <body>
     <h1 class="no-show">

diff --git a/js/editor.js b/js/editor.js
@@ -759,29 +759,36 @@ export async function initSentry() {
   });
 }
 
-export function registerSW() {
+export async function registerSW() {
   try {
-    if ("serviceWorker" in navigator) {
-      window.addEventListener("load", () => {
-        navigator.serviceWorker
-          .register("../sw.js")
-          .then((registration) => {
-            console.log(
-              "Service Worker registered with scope:",
-              registration.scope
-            );
-          })
-          .catch((error) => {
-            console.error("Service Worker registration failed:", error);
-          });
-      });
+    if (!("serviceWorker" in navigator)) {
+      console.error("Service Workers are not supported by this browser");
+      return;
     }
+    console.log("Registering Service Worker - - - -");
+
+    window.addEventListener("load", () => {
+      console.log("trying load - - - ");
+
+      navigator.serviceWorker
+        .register("../sw.js")
+        .then((registration) => {
+          console.log(
+            "Service Worker registered with scope:",
+            registration.scope
+          );
+        })
+        .catch((error) => {
+          console.error("Service Worker registration failed:", error);
+        });
+    });
   } catch (error) {
     console.error("Service Worker registration failed:", error);
   }
 }
 
 export async function init() {
+  registerSW();
   initSentry();
   setupDocument();
   await loadSettings();
@@ -792,5 +799,4 @@ export async function init() {
   setupListeners();
   evaluate(editor.innerText);
   updateOutputDisplay(output);
-  registerSW();
 }