For directories in preview column, dim cursor #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Aug 30, 2022
When preview is on and consists of a directory listing, make the cursor in there dimmer to emphasize it's not active. This makes it visually obvious which cursor is active at all times, without having to read the path. The active cursor is now always the rightmost bright one, regardless of whether the `preview` option is on or off. See screenshots in the pull request at gokcehan#924. Before this, I noticed that I often open a file by accident because I got confused which of the three cursors on the screen is the active one. In the future, I also hope this dimming could be used to show when an lf window loses focus, based on @laktak's implementation of focus tracking in gokcehan#861.
ilyagr
force-pushed
the
dim-preview-cursor
branch
from
bbfc692 to
e5138b2
Compare
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Sep 3, 2022
When preview is on and consists of a directory listing, make the cursor in there dimmer to emphasize it's not active. This makes it visually obvious which cursor is active at all times, without having to read the path. The active cursor is now always the rightmost bright one, regardless of whether the `preview` option is on or off. See screenshots in the pull request at gokcehan#924. Before this, I noticed that I often open a file by accident because I got confused which of the three cursors on the screen is the active one. In the future, I also hope this dimming could be used to show when an lf window loses focus, based on @laktak's implementation of focus tracking in gokcehan#861.
ilyagr
force-pushed
the
dim-preview-cursor
branch
from
e5138b2 to
fa3e7d7
Compare
|
Just pushed a minor update (improved naming). |
ilyagr
force-pushed
the
dim-preview-cursor
branch
from
fa3e7d7 to
0b1e970
Compare
|
Added a bugfix so that empty directories and similar situations get the same highlighting as non-empty ones. |
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Sep 20, 2022
This mainly merges gokcehan#924 with @laktak's gokcehan#861. This also merges in the `:keys` command (gokcehan#918) as well as and some unrelated minor corrections (currently dd5dc59).
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Oct 9, 2022
This mainly merges gokcehan#924 with @laktak's gokcehan#861. This also merges in the `:keys` command (gokcehan#918) as well as and some unrelated minor corrections (currently dd5dc59).
ilyagr
force-pushed
the
dim-preview-cursor
branch
from
9b72272 to
0aeffc5
Compare
|
Synced to master, reduced back to two commits (one for functionality, one for a no-op cleanup). |
When preview is on and consists of a directory listing, make the cursor in there dimmer to emphasize it's not active. This makes it visually obvious which cursor is active at all times, without having to read the path. The active cursor is now always the rightmost bright one, regardless of whether the `preview` option is on or off. See screenshots in the pull request at gokcehan#924. Before this, I noticed that I often open a file by accident because I got confused which of the three cursors on the screen is the active one.
Reduce number of arguments to printDir and list non-configurable colors
ilyagr
force-pushed
the
dim-preview-cursor
branch
from
0aeffc5 to
ecb2c02
Compare
|
@gokcehan Done, thanks for looking! |
|
I was also considering adding an option to choose whether the preview dir cursor is dim (as implemented here), normal (as it was before), or invisible. I didn't do it since I think it's better to have fewer options and a good default behavior whenever possible, but it remains a possibility. |
|
@ilyagr Thanks for the patch. |
gokcehan
added a commit
that referenced
this pull request
Dec 24, 2022
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Jan 19, 2023
…w panes This allows using a different style for the normal and preview cursor. See linked issues and PRs for the context. The default behavior is an underline, same as in gokcehan#1072, since it should not cause severe problems and be visible on all terminals. It can now be easily changed. Fixes gokcehan#1038 Follows up on: gokcehan#1072 gokcehan#924 gokcehan@b47cf6d5a5
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Jan 19, 2023
This defines new `cursorfmt` and `crusorpreviewfmt` options to style cursor in normal/preview panes. This allows using a different style for the normal and preview cursor. The documentation includes several possible values these options can be set to. The default behavior is an underline, same as in gokcehan#1072, since it should not cause severe problems and be visible on all terminals. It can now be easily changed, as explained in the docs. I also added an example to `etc/lfrc.example`. See linked issues and PRs for the more context. Fixes gokcehan#1038 Follows up on: gokcehan#1072 gokcehan#924 gokcehan@b47cf6d5a5
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Jan 19, 2023
This defines new `cursorfmt` and `crusorpreviewfmt` options to style cursor in normal/preview panes. This allows using a different style for the normal and preview cursor. The documentation includes several possible values these options can be set to. The default behavior is an underline, same as in gokcehan#1072, since it should not cause severe problems and be visible on all terminals. It can now be easily changed, as explained in the docs. I also added an example to `etc/lfrc.example`. See linked issues and PRs for the more context. Fixes gokcehan#1038 Follows up on: gokcehan#1072 gokcehan#924 gokcehan@b47cf6d5a5
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Jan 19, 2023
This defines new `cursorfmt` and `crusorpreviewfmt` options to style cursor in normal/preview panes. This allows using a different style for the normal and preview cursor. The documentation includes several possible values these options can be set to. The default behavior is an underline, same as in gokcehan#1072, since it should not cause severe problems and be visible on all terminals. It can now be easily changed, as explained in the docs. I also added an example to `etc/lfrc.example`. See linked issues and PRs for the more context. Fixes gokcehan#1038 Follows up on: gokcehan#1072 gokcehan#924 gokcehan@b47cf6d5a5
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Jan 20, 2023
This defines new `cursorfmt` and `crusorpreviewfmt` options to style cursor in normal/preview panes. This allows using a different style for the normal and preview cursor. The documentation includes several possible values these options can be set to. The default behavior is an underline, same as in gokcehan#1072, since it should not cause severe problems and be visible on all terminals. It can now be easily changed, as explained in the docs. I also added an example to `etc/lfrc.example`. See linked issues and PRs for the more context. Fixes gokcehan#1038 Follows up on: gokcehan#1072 gokcehan#924 gokcehan@b47cf6d5a5
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Jan 28, 2023
This restores functionality from gokcehan#924 reverted in gokcehan@b47cf6d5a5, while fixing gokcehan#1038. Unlike before, the cursor in the preview column is now an underline rather than a grey background. This seems to work on most terminals. In no case should the visibility of the file name itself be affected. For messages such as "empty" or "permission denied", the preview cursor is the same as the active cursor for now. There is no configuration, but there is nothing preventing adding config as discussed in gokcehan#1038 in the future. 
gokcehan
pushed a commit
that referenced
this pull request
Feb 11, 2023
…y `tagfmt` and `errorfmt` (#1086) * Allow separate styles for cursor in normal and preview panes This defines new `cursorfmt` and `crusorpreviewfmt` options to style cursor in normal/preview panes. This allows using a different style for the normal and preview cursor. The documentation includes several possible values these options can be set to. The default behavior is an underline, same as in #1072, since it should not cause severe problems and be visible on all terminals. It can now be easily changed, as explained in the docs. I also added an example to `etc/lfrc.example`. See linked issues and PRs for the more context. Fixes #1038 Follows up on: #1072 #924 b47cf6d5a5 * Simplify configuration of several formatting options This simplifies the configuration of `cursorfmt`, `cursorpreviewfmt`, `tagfmt`, and `errorfmt` options. In almost all usecases, the value of these options had to end with `%s\033[0m` to print the contents of filename/tag/error and reset the terminal style. Now, if `%s` is not part of the option's value, `%s\033[0m` is appended automatically. This simplifies configuration. I retained the same behavior as before when `%s` is part of the string for backwards compatibility. I think it should be considered deprecated, but it also causes no harm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing note
This PR consists of two commits: one that does all the work with
a small diff, and another one that is a no-op and tries to make
the code easier to read.
PR Description
When preview is on and consists of a directory listing, make the
cursor in there dimmer to emphasize it's not active (as in the first screenshot below). This makes it
visually obvious which cursor is active at all times, without
having to read the path. The active cursor is now always the
rightmost bright one, regardless of whether the
previewoptionis on or off.
For example, you can easily and without reading anything tell the difference between the following two situations:
Preview is on, we are in the second column (this PR in action).
Preview is off, we are in the third column (same as before this PR).
If the preview is on but shows a file rather than a directory, this PR doesn't change anything.
In an ideal world, the color for the dim cursor would be customizable, but there is currently no framework for specifying these sorts of colors in
lf(it could be a nonstandard extension to LS_COLORS, perhaps?). I picked a grey color with 50% brightness, which should be available on all terminals. I hope it will work OK for both bright and dark themes.More motivation
Before this, I noticed that I often open a file by accident because
I got confused which of the three cursors on the screen is the active
one.