Move get file extension logic to util #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limero
commented
Mar 31, 2024
Limero
force-pushed
the
file-ext-util
branch
5 times, most recently
from
32cbb9c to
73cf4ee
Compare
joelim-work
reviewed
Mar 31, 2024
joelim-work
reviewed
Apr 1, 2024
joelim-work
approved these changes
Apr 2, 2024
|
Just realized that this PR also fixes the bug described in #387 (comment) with the following files: I will update the PR description accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to @joelim-work's comment on this PR #1664 (review)
The changes that seem unrelated are automatic formatting by gofumpt, I can revert those if you don't want them applied