Make :maps work on Windows and add :cmaps.
#1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the `:maps` command from gokcehan#1146 work on Windows. This (as well as `:maps` itself) is based on @jackielli's work in gokcehan#1146 and gokcehan#1152. I intend to refactor the code in this or a separate PR, but I thought I'd submit the critical and simple bit first.
After the naming scheme from gokcehan#1146, it would seem weird to not have a :cmaps command. This could help with issues like gokcehan#876.
ilyagr
changed the title
:maps work on Windows:maps work on Windows and add :cmaps.
|
@ilyagr @jackielii Looks good, thanks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
:mapscommand from #1146 work on Windows and creates:cmaps.This (as well as
:mapsitself) is based on the work by @jackielii in #1146 and #1152.I intend to refactor the code in this or a separate PR, but I thought I'd submit the critical and simple bit first. Adding
:cmapsis also now trivial, and given the nice new naming scheme it would seem like an omission not to have it. (But I can remove it or split it in a separate PR if it needs more discussion).