Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: External svgs not rendering in top nav bar #297

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fix: External svgs not rendering in top nav bar #297

merged 1 commit into from
Jan 5, 2025

Conversation

526avijitgupta
Copy link
Member

Tested locally (bluesky icon being directly rendered from wikimedia url):

image

@526avijitgupta 526avijitgupta self-assigned this Jan 4, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 4, 2025 •
edited
Loading

✅ Deploy Preview for gokarna-hugo ready!

Name Link
🔨 Latest commit b559dc3
🔍 Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/677973d602a5200008a12a29
😎 Deploy Preview https://deploy-preview-297--gokarna-hugo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@526avijitgupta
Copy link
Member Author

@yashmehrotra @jamesericdavidson please review

@yashmehrotra yashmehrotra merged commit e1685de into main Jan 5, 2025
4 checks passed
@yashmehrotra yashmehrotra deleted the fix-external-svgs-not-showing branch January 5, 2025 04:16
@jamesericdavidson jamesericdavidson mentioned this pull request Jan 5, 2025
Closed
526avijitgupta added a commit that referenced this pull request Jan 5, 2025
@526avijitgupta
Revert "fix: External svgs not rendering in top nav bar (#297)"
efa5a0d 
This reverts commit e1685de.
yashmehrotra pushed a commit that referenced this pull request Jan 5, 2025
@526avijitgupta
Revert svg fix to prevent #301 (#304)
69435d3 
* Revert "chore: update bluesky url (#299)"

This reverts commit 3f103a1.

* Revert "fix: External svgs not rendering in top nav bar (#297)"

This reverts commit e1685de.
@jamesericdavidson
Copy link
Contributor

P.S. Simple Icons have a Bluesky SVG https://simpleicons.org/?q=bluesky

@yashmehrotra
Copy link
Collaborator

@jamesericdavidson Yeah, but we use feather in the top nav bar

Also, the bug is that injecting svgs don't work for top bar

@jamesericdavidson
Copy link
Contributor

jamesericdavidson commented Jan 27, 2025 •
edited
Loading

@yashmehrotra Good point. Feather haven't added any icons since Mar 30, 2022: https://github.com/feathericons/feather/releases

@jamesericdavidson
Copy link
Contributor

jamesericdavidson commented Jan 27, 2025 •
edited
Loading

@yashmehrotra @526avijitgupta In 2019, Feather icons decided not to add more brand icons, and defer that responsibility to Simple Icons: feathericons/feather#763 (comment) (the Bluesky request has sat dormant since Nov 15, 2024: feathericons/feather#1253)

Automattic (WordPress) maintain a social icon set, which could act as a supplement to Feather icons: https://github.com/Automattic/social-logos (they include Bluesky: https://wpcalypso.wordpress.com/devdocs/design/social-logo)

For posterity, Lucide is a frequently updated fork of Feather (but still doesn't feature a Bluesky icon): https://github.com/lucide-icons/lucide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashmehrotra yashmehrotra Awaiting requested review from yashmehrotra

Assignees

@526avijitgupta 526avijitgupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@526avijitgupta @jamesericdavidson @yashmehrotra