This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Updated handling of crashed application during test run. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I wouldn't mess with that. Ignored means that they were ignored in the code, ie with |
| @@ -61,7 +63,7 @@ private fun String.parseInstrumentationStatusValue(key: String): String = this | |||
| .trim() | |||
|
|
|||
| private fun String.throwIfError(output: File) = when { | |||
| contains("INSTRUMENTATION_RESULT: shortMsg=Process crashed") -> { | |||
| contains("INSTRUMENTATION_RESULT: shortMsg=") -> { | |||
There was a problem hiding this comment.
Let's add a test though?
yunikkk
force-pushed
the
dont-exit-if-crashed
branch
from
a5b481b to
f455738
Compare
|
Hey @artem-zinnatullin , lets merge this? |
|
Yeah sorry, I think GitHub stopped sending emails when you push new commits :( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, thats it, fixes #121)
It appears that crashes are reported differently under different OS revisions. I've got another example with
shortMsg=Native crashon Lollipop, too. So the common thing here isshortMsgand it should be sufficient to treat it as crash.With this PR test run will fail, but the excluded tests will remain silently ignored.
Seems to me that possible nicer option would be to refactor error handling the way that other tests are reported as
ignored. On the other hand it will be confusing, too.IMO we can live with such solution until we integrate test orchestrator or our own test runner which will run tests independently and allow to restart crashed application and failed test.
WDYT @artem-zinnatullin ?