Add configurable APK installation timeout. #109
Conversation
| description = "APK installation timeout in seconds. If not passed defaults to 120 seconds (2 minutes). Applicable to both test APK and APK under test.", | ||
| order = 11 | ||
| ) | ||
| var installTimeoutSeconds: Int = TimeUnit.MINUTES.toSeconds(2).toInt() |
There was a problem hiding this comment.
Not sure this is how you set default value, most likely JCommander will override that anyway
Can you add a test please?
| parseArgs(rawArgsWithOnlyRequiredFields + arrayOf("--install-timeout", "600")) | ||
| } | ||
|
|
||
| it("parses --install-timeout correctly") { |
There was a problem hiding this comment.
But what about default value? :)
|
@koral-- thanks! Pls report if it solved your issue :) |
|
OK, thanks for the quick response. |
|
Oh, so you use Gradle Plugin, patching 3 repositories is not so fun I
guess, glad we have fast and easy release process :)
…On Thu, Nov 9, 2017, 3:32 PM Karol Wrótniak ***@***.***> wrote:
OK, thanks for the quick response.
I'll create appropriate PR in
https://github.com/trevjonez/composer-gradle-plugin and check it ASAP.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#109 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA7B3HXG0BZNQnjiLF-17QrkcSoovtdzks5s04t7gaJpZM4QVqEW>
.
|
|
I have an issue open for it there already. trevjonez/composer-gradle-plugin#8 Shoot me a pr or I can get it in and updated first thing in the morning. |
|
this repo is in need of a readme update to reflect this new flag. |
|
Just added README update in #110. |
|
Oh, and other flags, I guess. Will add them separately. |
|
pr is up for this. any review is welcome. thus far the gradle plugin has been a solo effort so I will merge in an hour or so if nothing moves on it |
I would said that it is partially solved. Indeed installation time is not an issue now. So change from this PR is OK. But it seems that installation hangs when output file reaches 64KB. I'll investigate that further and create separate issue possibly. |
|
@koral-- yeah, what a "wonderful" world of programmatic binary invocations… |
gojuno/commander#7 continuation.