Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProtoMessage to fiber grpc Request #7

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Add ProtoMessage to fiber grpc Request #7

merged 3 commits into from
Oct 18, 2022

Conversation

pradithya
Copy link
Member

@pradithya pradithya commented Oct 17, 2022 •
edited
Loading

This PR contains modification of:

  1. Add Proto field and ProtoMessage() method to fiber grpc Request. This field is useful for fiber component that requires access to the protobuf object of the request without having to unmarshal from the Message
  2. Grpc request Clone will return itself since no modification is performed in any fiber components

@pradithya pradithya changed the title Avoid cloning Add ProtoMessage to fiber grpc Request Oct 18, 2022
@pradithya pradithya requested a review from leonlnj October 18, 2022 05:22
@pradithya pradithya marked this pull request as ready for review October 18, 2022 05:23
leonlnj
leonlnj approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradithya pradithya merged commit 013517a into main Oct 18, 2022
@pradithya pradithya mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonlnj leonlnj leonlnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradithya @leonlnj