-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate grpc dispatch proto marshaling overhead with Codec #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonlnj
commented
Sep 15, 2022
pradithya
reviewed
Sep 16, 2022
pradithya
reviewed
Sep 16, 2022
pradithya
reviewed
Sep 16, 2022
pradithya
reviewed
Sep 16, 2022
leonlnj
commented
Sep 16, 2022
pradithya
reviewed
Sep 16, 2022
pradithya
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this huge performance improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR seeks to improve the performance of grpc fiber by reducing proto marshalling overhead by using custom codec.
Fiber will no longer need to know the proto response of the
target routes
, any request sent to it will be expected to be in[]byte
. User of Fiber would need to marshal their own proto intoFiber.request
.The byte responses of route will simply be wrapped in the response and the user of Fiber would be expected to unmarshal them into the final proto message.
The default proto codec enforces
proto.message
on both the request and respond proto. Using the custom codec, this enforcement is loosen for type allowed in the codedc and the marshaling is skipped, making the below connection invocation possible with non proto message.Changes
response.go
andrequest.go
-Payload()
type changed frominterface{}
tobyte[]
grpc/dispatcher.go
- Remove server reflection implementationgrpc/codec.go
- codec implementation