[BUGFIX]: fix nil pointer bug in request.Clone() #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
http/request.go relies on
.GetBody()
function to fetch request payload whenfiberhttp.Request
is being cloned..GetBody()
function is expected to!= nil
, because it is always set in the factory method (fiber/http/request.go
Line 32 in 101a992
However, the
.Clone()
method doesn't set it and that causes panic in runtime when there is an attempt of cloning previously cloned request.Solution:
GetBody
function on the cloned requestClone()
method is called on the previously cloned request