Reimplement archetypes #9045
Merged
Reimplement archetypes #9045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
fix/archetype-index
branch
5 times, most recently
from
e726894
to
67344f4
Compare
The old implementation had some issues, mostly related to the context (e.g. name, file paths) passed to the template. This new implementation is using the exact same code path for evaluating the pages as in a regular build. This also makes it more robust and easier to reason about in a multilingual setup. Now, if you are explicit about the target path, Hugo will now always pick the correct mount and language: ```bash hugo new content/en/posts/my-first-post.md ``` Fixes gohugoio#9032 Fixes gohugoio#7589 Fixes gohugoio#9043 Fixes gohugoio#9046 Fixes gohugoio#9047
bep
force-pushed
the
fix/archetype-index
branch
from
67344f4
to
c84a190
Compare
|
Took it for a spin. Very nice. Thanks. |
|
@jmooring Yea, I merged it boldly as I need some of the code for some other stuff I'm woring on. Let me know if I ... messed up something. But I suspect it should in most cases be an improvement. |
regisphilibert
pushed a commit
to theNewDynamic/gohugo-theme-ananke
that referenced
this pull request
Dec 2, 2021
With Hugo v0.88.1 and earlier, ContentBaseName and TranslationBaseName both returned "index" when creating a leaf bundle with hugo new. This is a known bug, addressed with gohugoio/hugo#9045. With this PR: hugo new post/my-first-post/index.md will produce: title: "My First Post" instead of: title: "Index"
Remicck
pushed a commit
to Remicck/gohugo-theme-ananke
that referenced
this pull request
Mar 7, 2022
With Hugo v0.88.1 and earlier, ContentBaseName and TranslationBaseName both returned "index" when creating a leaf bundle with hugo new. This is a known bug, addressed with gohugoio/hugo#9045. With this PR: hugo new post/my-first-post/index.md will produce: title: "My First Post" instead of: title: "Index"
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation had some issues, mostly related to the context (e.g. name, file paths) passed to the template.
This new implementation is using the exact same code path for evaluating the pages as in a regular build.
This also makes it more robust and easier to reason about in a multilingual setup.
Now, if you are explicit about the target path, Hugo will now always pick the correct mount and language:
Fixes #9032
Fixes #7589
Fixes #9043
Fixes #9046