-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tplimpl: Added shortcode for cloaking email #3935
Conversation
Looking at the PR now that I've submitted it I see that the code's readability is subpar. Should I split the shortcode output on multiple lines? |
Hi guys/gals, I know this PR may be difficult to review and it's not obvious that this is a good solution. But let me know if there's anything I can do to make your job of reviewing it easier. You should also feel free to close the PR if you don't think this is a good fit for Hugo. I won't mind 😄 |
This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help. |
This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help. |
@danieka sorry for not getting back to you sooner on this. This PR looks good, but I think this falls a little outside of the scope of what in the Hugo core. We are working on making it easier to "share shortcodes" as components, and the next Hugo version (tomorrow) will be a step in that direction. Again, thanks for this contribution, but I feel that this has to wait. |
@danieka may be of interest to you https://discourse.gohugo.io/t/hugo-theme-utils/12376 |
@RealOrangeOne interesting, I'll make a PR to your repo as soon as I have some free time |
@bep No problem 😄 I totally get, and agree, with your point. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #3886