Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tplimpl: Added shortcode for cloaking email #3935

Closed
wants to merge 1 commit into from

Conversation

danieka
Copy link
Contributor

@danieka danieka commented Oct 3, 2017

Fixes #3886

@danieka
Copy link
Contributor Author

danieka commented Oct 3, 2017

Looking at the PR now that I've submitted it I see that the code's readability is subpar. Should I split the shortcode output on multiple lines?

@danieka
Copy link
Contributor Author

danieka commented Nov 13, 2017

Hi guys/gals,

I know this PR may be difficult to review and it's not obvious that this is a good solution. But let me know if there's anything I can do to make your job of reviewing it easier. You should also feel free to close the PR if you don't think this is a good fit for Hugo. I won't mind 😄

@martignoni martignoni mentioned this pull request Jan 24, 2018
@stale
Copy link

stale bot commented Feb 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Feb 11, 2018
@bep bep added the Keep label Feb 11, 2018
@stale stale bot removed the Stale label Feb 11, 2018
@bep bep added Stale and removed Keep labels Feb 11, 2018
@stale stale bot removed the Stale label Feb 11, 2018
@stale
Copy link

stale bot commented Jun 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Jun 11, 2018
@bep bep added the Keep label Jun 11, 2018
@stale stale bot removed the Stale label Jun 11, 2018
@bep
Copy link
Member

bep commented Jun 11, 2018

@danieka sorry for not getting back to you sooner on this. This PR looks good, but I think this falls a little outside of the scope of what in the Hugo core. We are working on making it easier to "share shortcodes" as components, and the next Hugo version (tomorrow) will be a step in that direction.

Again, thanks for this contribution, but I feel that this has to wait.

@bep bep closed this Jun 11, 2018
@RealOrangeOne
Copy link
Contributor

@danieka may be of interest to you https://discourse.gohugo.io/t/hugo-theme-utils/12376

@danieka
Copy link
Contributor Author

danieka commented Jun 27, 2018

@RealOrangeOne interesting, I'll make a PR to your repo as soon as I have some free time

@danieka
Copy link
Contributor Author

danieka commented Jun 27, 2018

@bep No problem 😄 I totally get, and agree, with your point.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloak e-mail
3 participants