Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpl/tplimpl: Remove leading whitespaces produced by Youtube shortcode #13325

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

alex-shpak
Copy link
Contributor

Hi! Coming from issue opened in my theme, there is an issue rendering youtube shortcode if it is nested in another shortcode in {{% %}} mode. youtube shortcode outputs a leading whitespace, which is then rendered as a blockquote.

Thanks

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
All committers have signed the CLA.

@jmooring
Copy link
Member

Please run go test ./... locally and then fix the test assertion. Thanks.

@alex-shpak
Copy link
Contributor Author

Would have seen it if I have switched to correct branch after clone 😅
checksums pushed.

@jmooring
Copy link
Member

One more thing, please squash your commits with a new commit message that follows these giudelines, something like:

tpl/tplimpl: Adjust whitespace handling in YouTube shortcode

@alex-shpak
Copy link
Contributor Author

Done :)

@jmooring jmooring changed the title Remove leading whitespaces before youtube shortcode output tpl/tplimpl: Remove leading whitespaces produced by Youtube shortcode Jan 31, 2025
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bep bep merged commit 13b208e into gohugoio:master Jan 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants