Update gocloud and docs for S3-Compatible Endpoints #13158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to follow the docs, Configuring your first
deployment gives an
example of using an S3-Compatible endpoint. I could not get this to work with the current codebase.
gocloud 0.40.0 released on 2024-10-10 includes a
bugfix google/go-cloud#3473 which allows specifying a custom endpoint in an s3 url to
publish to an s3-compatible service, such as MinIO as was linked in that PR
minio/docs#406 (comment).
I updated the docs to include an s3 URL that works with the updated gocloud library (tested against my MinIO
instance) with example parameters.
Resolves #13159