content_map_page: Ensure homepage exists #11491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was possible to create an _index.md, but have it not be built, such as by setting `draft: true`. This would result in there being no homepage, and when e.g. a theme would call `.Site.Home`, this would result in a “runtime error: invalid memory address or nil pointer dereference”. Now, if the homepage does not end up being built, we fall back to creating a default homepage, as if _index.md never exited. Fixes gohugoio#11441
vladh
force-pushed
the
ensure-homepage-exists
branch
from
7c335b1
to
f6f3da3
Compare
|
Closing in favor of #11894. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible to create an _index.md, but have it not be built, such as by setting
draft: true. This would result in there being no homepage, and when e.g. a theme would call.Site.Home, this would result in a “runtime error: invalid memory address or nil pointer dereference”. Now, if the homepage does not end up being built, we fall back to creating a default homepage, as if _index.md never exited.Fixes #11441