Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add golangci-lint #23

Merged
merged 4 commits into from
Jul 12, 2023
Merged

chore: add golangci-lint #23

merged 4 commits into from
Jul 12, 2023

Conversation

ahkui
Copy link
Contributor

@ahkui ahkui commented Jul 3, 2023

規則從 GitLab 官方 Image 中提取

registry.gitlab.com/gitlab-org/gitlab-build-images:golangci-lint-alpine

@ahkui ahkui mentioned this pull request Jul 3, 2023
@ahkui
Copy link
Contributor Author

ahkui commented Jul 3, 2023

以上設定如有不適用的可直接調整

@gohiei
Copy link
Owner

gohiei commented Jul 3, 2023

We should modify the codebase if we want to use golangci-lint
Such as: type/func comment

.github/workflows/golangci-lint.yml Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
.vscode/settings.json Show resolved Hide resolved
@ahkui ahkui force-pushed the main branch 4 times, most recently from a012dfd to 06a9e8a Compare July 4, 2023 11:05
@ahkui
Copy link
Contributor Author

ahkui commented Jul 4, 2023

目前有三個插件未啟用 prealloc wsl lll

ahkui and others added 2 commits July 12, 2023 10:08
Signed-off-by: ahkui <ahkui@outlook.com>
Co-authored-by: TCCinCY <41672399+TCCinCY@users.noreply.github.com>
Signed-off-by: ahkui <ahkui@outlook.com>
.golangci.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
Signed-off-by: ahkui <ahkui@outlook.com>
Signed-off-by: ahkui <ahkui@outlook.com>
@gohiei gohiei merged commit f165757 into gohiei:main Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants