Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default Horizontal Scrollbar in Replication Page #21033

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

bupd
Copy link
Member

@bupd bupd commented Oct 13, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

  • Resolved an issue where a horizontal scrollbar appeared unnecessarily due to the last table column being hidden, leaving a gap. By rearranging the columns so the last declared column is always visible, the scrollbar issue is fixed.
  • This simple change ensures the table layout works as expected without any extra scrollbars by default.

Before

scroll in replication bug

After

fixed scrollbar

Issue being fixed

Fixes Unwanted Scrollbar in Replication page.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

bupd added 2 commits October 16, 2024 18:46
Signed-off-by: bupd <bupdprasanth@gmail.com>
* updates replication hidden columns order.

Signed-off-by: bupd <bupdprasanth@gmail.com>
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.09%. Comparing base (c8c11b4) to head (71b12e8).
Report is 300 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21033       +/-   ##
===========================================
+ Coverage   45.36%   66.09%   +20.72%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114645   +101312     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75769    +69720     
- Misses       6983    34734    +27751     
- Partials      301     4142     +3841     
Flag Coverage Δ
unittests 66.09% <ø> (+20.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

Copy link
Contributor

@xuelichao xuelichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vad1mo Vad1mo merged commit e4b6a09 into goharbor:main Oct 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants