Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless error check for scan data export job #20883

Merged
merged 2 commits into from
Aug 30, 2024
Merged

refactor: remove useless error check for scan data export job #20883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb3b2c4
refactor: remove useless error check for scan data export job
chlins Aug 28, 2024
b32a79e
Merge branch 'main' into refactor/cve-export-job-error-check
MinerYang Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/jobservice/job/impl/scandataexport/scan_data_export.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,20 +180,17 @@ func (sde *ScanDataExport) updateExecAttributes(ctx job.Context, params job.Para
}

func (sde *ScanDataExport) writeCsvFile(ctx job.Context, params job.Parameters, fileName string) error {
logger := ctx.GetLogger()
csvFile, err := os.OpenFile(fileName, os.O_WRONLY|os.O_CREATE|os.O_APPEND, os.ModePerm)
if err != nil {
logger.Errorf("Failed to create CSV export file %s. Error : %v", fileName, err)
return err
}
systemContext := ctx.SystemContext()
defer csvFile.Close()

logger := ctx.GetLogger()
if err != nil {
logger.Errorf("Failed to create CSV export file %s. Error : %v", fileName, err)
return err
}
logger.Infof("Created CSV export file %s", csvFile.Name())

systemContext := ctx.SystemContext()
var exportParams export.Params
var artIDGroups [][]int64

Expand Down
Loading