Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable robot full access #20754

Merged
merged 3 commits into from
Sep 26, 2024

Merge branch 'main' into robot-acc

9ce12fa
Select commit
Loading
Failed to load commit list.
Merged

enable robot full access #20754

Merge branch 'main' into robot-acc
9ce12fa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2024 in 1s

66.63% (+21.26%) compared to c8c11b4

View this Pull Request on Codecov

66.63% (+21.26%) compared to c8c11b4

Details

Codecov Report

Attention: Patch coverage is 19.02174% with 149 lines in your changes missing coverage. Please review.

Project coverage is 66.63%. Comparing base (c8c11b4) to head (9ce12fa).
Report is 282 commits behind head on main.

Files with missing lines Patch % Lines
src/server/v2.0/handler/robot.go 23.72% 90 Missing ⚠️
src/common/rbac/const.go 10.20% 44 Missing ⚠️
src/controller/robot/controller.go 0.00% 12 Missing ⚠️
src/server/v2.0/handler/permissions.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20754       +/-   ##
===========================================
+ Coverage   45.36%   66.63%   +21.26%     
===========================================
  Files         244     1048      +804     
  Lines       13333   114443   +101110     
  Branches     2719     2850      +131     
===========================================
+ Hits         6049    76260    +70211     
- Misses       6983    34292    +27309     
- Partials      301     3891     +3590     
Files with missing lines Coverage Δ
src/controller/robot/model.go 100.00% <ø> (ø)
src/controller/scan/base_controller.go 56.98% <100.00%> (ø)
src/server/v2.0/handler/permissions.go 0.00% <0.00%> (ø)
src/controller/robot/controller.go 56.18% <0.00%> (ø)
src/common/rbac/const.go 10.20% <10.20%> (ø)
src/server/v2.0/handler/robot.go 11.71% <23.72%> (ø)

... and 1282 files with indirect coverage changes