Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new type Store in content #158

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Desiki-high
Copy link
Collaborator

@Desiki-high Desiki-high commented Jul 7, 2023

To complete more custom features of the content store. We need to wrap the content.store to call the function inner store.

Changes:

  • Add new type Store to wrap content.store.
  • Move UpdateTime call from fetch to Store.ReaderAt.
  • Move newStore and NewDB to newContent.

Reference: #141.

@Desiki-high
Copy link
Collaborator Author

@imeoer PTAL.

pkg/content/store.go Outdated Show resolved Hide resolved
pkg/content/local.go Outdated Show resolved Hide resolved
Store wrap the content store, we can use Store to complete custom feature.
Such as call the UpdateTime in content store ReaderAt.
We also move the newStore and NewDB to newContent.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 5acde6c into goharbor:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants