-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support cznic/ql backend #880
Comments
Hi, thanks your feedback! But it's really depends on how far cc @lunny |
It looks to me from what I can see that the issue raised against ql were addressed. It would probably be helpful if the blocking issues that are outstanding actually be listed. |
I created a label |
Just talked to the author of xorm(@lunny), and just a note of example use ql and xorm: https://github.com/go-xorm/admin |
Sorry, I have renamed https://github.com/go-xorm/admin to https://github.com/go-xorm/dbweb. And use http://github.com/lunny/nodb instead http://github.com/cznic/ql to store meta data. |
Such a bad guy! |
This will not be supported as another better option is coming up. https://github.com/pingcap/tidb |
Not good.
That's much younger, less well tested and I can see whole sections of code from other people's work used without attribution (@cznic, take a look at the btree package in kv).
|
Without attribution? They explecitly say thank you to @cznic and reference to him Oo And it sounds much better from my point of view, especially the roadmap... |
I'm sorry, but a trite sentence doesn't make up for removing the copyright notice on the file. How many other files have been similarly taken. Roadmap is not implementation. I trust cznic's code because he has an excellent track record of quallity - ql is extensively tested, looking at tidb so far, I don't see that. Further, for a single machine install - why I filed the issue - a distributed db is overkill. |
For me, waiting for ql or tidb is same. Both of them are not usable by Gogs. |
If they are the same, don't close the issue. |
But we've waited too long for ql and no sign I can see xorm is going to support it fully. 😭 |
OK, that's a different issue. xorm is the problem. Question for you, what is a the lowest golang/go issue number? How long has that been waiting? |
It is same in the Gogs's point of view, if xorm is not going to support it, Gogs is not going to, even if ql has all features that Gogs needs as long as Gogs are still using xorm.
I don't know and don't need to know. There is no necessity of how long to stop waiting between two projects. |
Issues are your memory. If you intentionally forget things because they haven't been done in time, they won't be done. |
Yes, but decision has to be made. |
Yup, I've made a decision. |
I'm think sometimes ago for writing cznic/ql support. I don't like xorm and
|
Thanks: pingcap/tidb#45 |
Repeat of #46 - closed without resolution.
The text was updated successfully, but these errors were encountered: