Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cznic/ql backend #880

Closed
kortschak opened this issue Jan 30, 2015 · 20 comments
Closed

support cznic/ql backend #880

kortschak opened this issue Jan 30, 2015 · 20 comments
Labels
🎯 feature Categorizes as related to a new feature status: await It is time consuming 🤷 third-party It's someone else's shit
Milestone

Comments

@kortschak
Copy link

Repeat of #46 - closed without resolution.

@unknwon unknwon added priority: maybe You know what, it sounds good 🤷 third-party It's someone else's shit labels Jan 30, 2015
@unknwon
Copy link
Member

unknwon commented Jan 30, 2015

Hi, thanks your feedback!

But it's really depends on how far cznic/ql goes and when would xorm supports it.

cc @lunny

@kortschak
Copy link
Author

It looks to me from what I can see that the issue raised against ql were addressed. It would probably be helpful if the blocking issues that are outstanding actually be listed.

@unknwon unknwon added the status: await It is time consuming label Jan 30, 2015
@unknwon
Copy link
Member

unknwon commented Jan 30, 2015

I created a label standby so that people know we're waiting for third-party providers.

@unknwon
Copy link
Member

unknwon commented Jan 30, 2015

Just talked to the author of xorm(@lunny), and ql is almost ready for testing with Gogs, I'm not sure how far it would go(maybe stuck on some weird points), but will start working on it soon!

just a note of example use ql and xorm: https://github.com/go-xorm/admin

@unknwon unknwon added 🎯 feature Categorizes as related to a new feature and removed priority: maybe You know what, it sounds good labels Jan 30, 2015
@lunny
Copy link
Contributor

lunny commented Feb 3, 2015

Sorry, I have renamed https://github.com/go-xorm/admin to https://github.com/go-xorm/dbweb. And use http://github.com/lunny/nodb instead http://github.com/cznic/ql to store meta data.

@unknwon
Copy link
Member

unknwon commented Feb 3, 2015

Sorry, I have renamed https://github.com/go-xorm/admin to https://github.com/go-xorm/dbweb. And use http://github.com/lunny/nodb instead http://github.com/cznic/ql to store meta data.

Such a bad guy!

@unknwon
Copy link
Member

unknwon commented Sep 6, 2015

This will not be supported as another better option is coming up. https://github.com/pingcap/tidb

@unknwon unknwon closed this as completed Sep 6, 2015
@unknwon unknwon added this to the 0.7.0 milestone Sep 6, 2015
@kortschak
Copy link
Author

kortschak commented Sep 6, 2015 via email

@tboerger
Copy link
Contributor

tboerger commented Sep 6, 2015

Without attribution? They explecitly say thank you to @cznic and reference to him Oo

And it sounds much better from my point of view, especially the roadmap...

@kortschak
Copy link
Author

I'm sorry, but a trite sentence doesn't make up for removing the copyright notice on the file. How many other files have been similarly taken.

Roadmap is not implementation. I trust cznic's code because he has an excellent track record of quallity - ql is extensively tested, looking at tidb so far, I don't see that. Further, for a single machine install - why I filed the issue - a distributed db is overkill.

@unknwon
Copy link
Member

unknwon commented Sep 6, 2015

For me, waiting for ql or tidb is same. Both of them are not usable by Gogs.

@kortschak
Copy link
Author

If they are the same, don't close the issue.

@unknwon
Copy link
Member

unknwon commented Sep 6, 2015

But we've waited too long for ql and no sign I can see xorm is going to support it fully. 😭

@kortschak
Copy link
Author

But we've waited too long for ql and no sign I can see xorm is going to support it fully.

OK, that's a different issue. xorm is the problem.

Question for you, what is a the lowest golang/go issue number? How long has that been waiting?

@unknwon
Copy link
Member

unknwon commented Sep 6, 2015

OK, that's a different issue. xorm is the problem.

It is same in the Gogs's point of view, if xorm is not going to support it, Gogs is not going to, even if ql has all features that Gogs needs as long as Gogs are still using xorm.

Question for you, what is a the lowest golang/go issue number? How long has that been waiting?

I don't know and don't need to know. There is no necessity of how long to stop waiting between two projects.

@kortschak
Copy link
Author

Issues are your memory. If you intentionally forget things because they haven't been done in time, they won't be done.

@unknwon
Copy link
Member

unknwon commented Sep 6, 2015

If you intentionally forget things because they haven't been done in time, they won't be done.

Yes, but decision has to be made.

@kortschak
Copy link
Author

Yup, I've made a decision.

@vtolstov
Copy link

vtolstov commented Sep 6, 2015

I'm think sometimes ago for writing cznic/ql support. I don't like xorm and
prefer writing interface for getting and setting needed things. But I'm
switch to gitea, and prepare pr to gitea...
07 сент. 2015 г. 0:04 пользователь "Dan Kortschak" notifications@github.com
написал:

Yup, I've made a decision.


Reply to this email directly or view it on GitHub
#880 (comment).

@cznic
Copy link

cznic commented Sep 7, 2015

@kortschak

(@cznic, take a look at the btree package in kv).

Thanks: pingcap/tidb#45

@unknwon unknwon modified the milestones: 0.8.0, 0.7.0 Oct 24, 2015
@unknwon unknwon removed this from the 0.8.0 milestone Oct 24, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎯 feature Categorizes as related to a new feature status: await It is time consuming 🤷 third-party It's someone else's shit
Projects
None yet
Development

No branches or pull requests

6 participants