Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate issue with using grpc-gateway with gogoproto.stdtime = true #18

Closed
johanbrandhorst opened this issue Jun 25, 2018 · 1 comment
Closed

Investigate issue with using grpc-gateway with gogoproto.stdtime = true #18

johanbrandhorst opened this issue Jun 25, 2018 · 1 comment

Comments

@johanbrandhorst
Copy link
Member

At $work we ran into an issue with using the gogoproto.stdtime as a query parameter to grpc-gateway. The problem is this code https://github.com/grpc-ecosystem/grpc-gateway/blob/ee3ef70b7777cde4e61e4e224cb11e92beecee6a/runtime/query.go#L208 that only handles destination types that implement XXX_WellKnownType. More investigation necessary.
@johanbrandhorst
Copy link
Member Author

This was fixed in grpc-ecosystem/grpc-gateway#693

johanbrandhorst added a commit that referenced this issue Jul 7, 2018
@johanbrandhorst
Add example of time and duration in queries
ed902fb 
To show stdtime and stdduration working with query parameters,
it is now possible to filter users based on create date.

Fixes #18
@johanbrandhorst johanbrandhorst mentioned this issue Jul 7, 2018
Merged
johanbrandhorst added a commit that referenced this issue Jul 7, 2018
@johanbrandhorst
Add example of time and duration in queries
fadeea1 
To show stdtime and stdduration working with query parameters,
it is now possible to filter users based on create date.

Fixes #18
johanbrandhorst added a commit that referenced this issue Jul 7, 2018
@johanbrandhorst
Add example of time and duration in queries
fcd7faa 
To show stdtime and stdduration working with query parameters,
it is now possible to filter users based on create date.

Fixes #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanbrandhorst