Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contrib/registry/nacos/v2): Switch nacos-sdk-go dependencies to the official version #3729

Closed
wants to merge 2 commits into from

Conversation

LanceAdd
Copy link
Contributor

Switch nacos-sdk-go dependencies to the official version
Update the go.mod file and nacos related code to update the nacos-sdk-go dependency from the joy999 branch to the official version of nacos-group. This change includes updating the package path and referencing the official version of nacos-sdk-go/v2, as well as removing references to older versions. This change is to solve the startup failure issue caused by repeated initialization of monitor when using Nacos as the configuration center and registry center
fix: #3680

切换nacos-sdk-go依赖至官方版本
更新go.mod文件及nacos相关代码,将nacos-sdk-go依赖从joy999的分支更新至nacos-group的官方版本。此更改包括更新包路径和引用官方版本的nacos-sdk-go/v2,以及移除对旧版本的引用。
此次更改是为了解决使用nacos作为配置中心和注册中心时monitor重复初始化造成的启动失败
@LanceAdd LanceAdd changed the title [LanceAdd]Switch nacos-sdk-go dependencies to the official version feat(contrib/registry/nacos/v2): Switch nacos-sdk-go dependencies to the official version Aug 15, 2024
Copy link

@gqcn
Copy link
Member

gqcn commented Sep 9, 2024

@LanceAdd Thank you for your PR, but this is duplicated with #3745

@gqcn gqcn closed this Sep 9, 2024
@gqcn gqcn added the duplicated label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contrib/registry/nacos/v2: panic: duplicate metrics collector registration attempted
3 participants