Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net/ghttp/): fix the issue of using application/octet stream to upload large files causing excessive memory and crashing #3693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TotoroZuo
Copy link

The reason for this problem is that when creating RouterFunc initializes the request, it calls the MakeBodyRepeatableRead method to write the r.body to memory and change it to Repeatable. However, pure binary files do not require formatting of either the form or the body

So the solution is to detect the application/octet stream type and exit it early in the formatted form and body methods

Fixes #3692

…eam would copy the body and cause excessive memory usage
@@ -229,6 +229,12 @@ func (r *Request) parseBody() {
if r.parsedBody {
return
}

// If it's binary data, it does not need to be parsed.
if contentType := r.Header.Get("Content-Type"); contentType == "" || gstr.Contains(contentType, "octet-stream") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • condition contentType == "" might be removed?
  • missing associated unit testing case for the changes.

@gqcn
Copy link
Member

gqcn commented Sep 23, 2024

@TotoroZuo Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants