Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(os/gcron): add graceful shutdown support #3625

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Conversation

vector233
Copy link
Contributor

I found that cron job do not support graceful shutdown, so I tried to implement it. If there are any problems, please point them out and I will fix them.

Copy link
Member

@oldme-git oldme-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vector233 Thinks

Copy link
Member

@oldme-git oldme-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@oldme-git oldme-git closed this Jun 4, 2024
@oldme-git oldme-git reopened this Jun 4, 2024
os/gcron/gcron_cron.go Outdated Show resolved Hide resolved
os/gcron/gcron_entry.go Outdated Show resolved Hide resolved
os/gcron/gcron_z_example_1_test.go Outdated Show resolved Hide resolved
os/gcron/gcron_z_unit_test.go Outdated Show resolved Hide resolved
@oldme-git oldme-git requested a review from gqcn June 4, 2024 09:45
os/gcron/gcron_entry.go Outdated Show resolved Hide resolved
os/gcron/gcron_z_unit_test.go Outdated Show resolved Hide resolved
os/gcron/gcron_cron.go Outdated Show resolved Hide resolved
@gqcn gqcn changed the title os/gcron: add cron job graceful shutdown os/gcron: add graceful shutdown support Jun 4, 2024
@vector233 vector233 requested review from oldme-git and gqcn June 5, 2024 12:40
os/gcron/gcron.go Outdated Show resolved Hide resolved
@vector233
Copy link
Contributor Author

how to re run ci?

@oldme-git
Copy link
Member

how to re run ci?

Have ran agian

@vector233 vector233 requested a review from gqcn June 19, 2024 13:05
@gqcn gqcn merged commit 8824b8b into gogf:master Jun 25, 2024
23 checks passed
@gqcn gqcn changed the title os/gcron: add graceful shutdown support feat(os/gcron): add graceful shutdown support Jun 26, 2024
@vector233 vector233 deleted the gcron branch July 2, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants