-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(os/gcron): add graceful shutdown support #3625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldme-git
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vector233 Thinks
oldme-git
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
oldme-git
requested changes
Jun 4, 2024
gqcn
requested changes
Jun 4, 2024
gqcn
changed the title
os/gcron: add cron job graceful shutdown
os/gcron: add graceful shutdown support
Jun 4, 2024
hailaz
approved these changes
Jun 6, 2024
oldme-git
approved these changes
Jun 6, 2024
gqcn
requested changes
Jun 18, 2024
how to re run ci? |
Have ran agian |
gqcn
approved these changes
Jun 25, 2024
gqcn
changed the title
os/gcron: add graceful shutdown support
feat(os/gcron): add graceful shutdown support
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that cron job do not support graceful shutdown, so I tried to implement it. If there are any problems, please point them out and I will fix them.