refactor(cmd/gf): improve gf gen ctrl using ast
#3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gqcn
requested changes
May 30, 2024
gqcn
requested changes
Jun 4, 2024
gqcn
approved these changes
Jun 4, 2024
gqcn
changed the title
gqcn
changed the title
gf gen ctrl using ast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear review:
把另外一处正则替换成
AST，现在ctrl还有两处正则，但是正则的内容来源于模板，比较简单，可以不使用AST。另外，调整了一下单测，把一些基本的测试纳入到基础测试里