Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(os/glog): #3200 empty content in glog handler after structure logging feature supported #3475

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Apr 11, 2024

No description provided.

Copy link
Member

@hailaz hailaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gqcn
Copy link
Member Author

gqcn commented Apr 22, 2024

还是没有修复,需要一个单元测试检查。 https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

@hailaz 其实上是这个Content的作用变为了自定义内容,不再默认格式化填充。如果需要使用默认的日志格式,那么提供了一个ValuesContent方法可以获取。

@hailaz
Copy link
Member

hailaz commented Apr 22, 2024

还是没有修复,需要一个单元测试检查。 https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

@hailaz 其实上是这个Content的作用变为了自定义内容,不再默认格式化填充。如果需要使用默认的日志格式,那么提供了一个ValuesContent方法可以获取。

现在缺少一个获取原始日志内容的属性,以前是Content,不然自定义日志格式就没法用了。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Still no fix, needs a unit test check. https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

In fact, the function of this Content has been changed to customized content, and it is no longer formatted and filled by default. If you need to use the default log format, a ValuesContent method is provided to obtain it.

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Still no fix, needs a unit test check. https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

@hailaz In fact, the function of this Content has been changed to customized content, and it is no longer formatted and filled by default. If you need to use the default log format, a ValuesContent method is provided to obtain it.

There is now a missing attribute to obtain the original log content. It used to be Content, otherwise the custom log format will not be available.

@gqcn
Copy link
Member Author

gqcn commented Apr 23, 2024

还是没有修复,需要一个单元测试检查。 https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

@hailaz 其实上是这个Content的作用变为了自定义内容,不再默认格式化填充。如果需要使用默认的日志格式,那么提供了一个ValuesContent方法可以获取。

现在缺少一个获取原始日志内容的属性,以前是Content,不然自定义日志格式就没法用了。

现在是通过ValuesContent()方法获取。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Still no fix, needs a unit test check. https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

@hailaz In fact, the function of this Content has been changed to customized content, and it is no longer formatted and filled by default. If you need to use the default log format, a ValuesContent method is provided to obtain it.

There is now a missing attribute to obtain the original log content. It used to be Content, otherwise the custom log format will not be available.

Now it is obtained through the ValuesContent() method.

@hailaz
Copy link
Member

hailaz commented Apr 23, 2024

还是没有修复,需要一个单元测试检查。 https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

@hailaz 其实上是这个Content的作用变为了自定义内容,不再默认格式化填充。如果需要使用默认的日志格式,那么提供了一个ValuesContent方法可以获取。

现在缺少一个获取原始日志内容的属性,以前是Content,不然自定义日志格式就没法用了。

现在是通过ValuesContent()方法获取。

噢,那加个单测吧

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Still no fix, needs a unit test check. https://github.com/gogf/gf/pull/2919/files#diff-0950fd3e63cfb4b28566d3c8332c953272a247a2ac36d50cf6b4e299f1aea419L208

@hailaz In fact, the function of this Content has been changed to customized content, and it is no longer formatted and filled by default. If you need to use the default log format, a ValuesContent method is provided to obtain it.

There is now a missing attribute to obtain the original log content. It used to be Content, otherwise the custom log format will not be available.

Now it is obtained through the ValuesContent() method.

Oh, let’s add a single test

@hailaz
Copy link
Member

hailaz commented Apr 24, 2024

@gqcn 我改了下判断内容,这样有不兼容变动都能通过单测发现。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@gqcn I changed the judgment content so that any incompatible changes can be discovered through single testing.

@gqcn gqcn merged commit cc98e57 into master Apr 25, 2024
48 checks passed
@gqcn gqcn deleted the fix/3200 branch April 25, 2024 11:13
@gqcn gqcn changed the title fix: #3200 empty content in glog handler after structure logging feature supported fix(os/glog): #3200 empty content in glog handler after structure logging feature supported Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants