Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing use printToStdout, printToFile and printToWriter at the same time for Logger of package glog #2990

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

dabubus
Copy link
Contributor

@dabubus dabubus commented Sep 27, 2023

use printToStdout ,printToFile and printToWriter at the same time

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (569cbb0) 77.28% compared to head (f1cc6a0) 77.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2990      +/-   ##
==========================================
+ Coverage   77.28%   77.30%   +0.01%     
==========================================
  Files         645      645              
  Lines       54287    54284       -3     
==========================================
+ Hits        41955    41962       +7     
+ Misses      10226    10218       -8     
+ Partials     2106     2104       -2     
Flag Coverage Δ
go-1.18-386 77.32% <72.72%> (?)
go-1.18-amd64 77.35% <72.72%> (+0.06%) ⬆️
go-1.19-386 77.24% <72.72%> (-0.02%) ⬇️
go-1.19-amd64 77.19% <72.72%> (-0.06%) ⬇️
go-1.20-386 77.29% <72.72%> (?)
go-1.20-amd64 77.34% <72.72%> (+0.03%) ⬆️
go-1.21-386 77.28% <72.72%> (-0.03%) ⬇️
go-1.21-amd64 77.35% <72.72%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
os/glog/glog_logger.go 59.93% <72.72%> (+0.24%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gqcn gqcn changed the title glog doDefaultPrint allowing use printToStdout, printToFile and printToWriter at the same time for Logger of package glog Oct 7, 2023
@gqcn gqcn merged commit 02f1cc7 into gogf:master Oct 7, 2023
12 checks passed
@dabubus dabubus deleted the glog-printToWriter branch October 8, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants