Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add consul config adapter #2964

Merged
merged 7 commits into from
Sep 25, 2023
Merged

add consul config adapter #2964

merged 7 commits into from
Sep 25, 2023

Conversation

monchickey
Copy link
Contributor

@monchickey monchickey commented Sep 14, 2023

Add consul implements gcfg.Adapter using consul service.

@monchickey monchickey changed the title add consul config adapter and example add consul config adapter Sep 14, 2023
contrib/config/consul/consul.go Outdated Show resolved Hide resolved
contrib/config/consul/consul.go Outdated Show resolved Hide resolved
contrib/config/consul/consul.go Outdated Show resolved Hide resolved
contrib/config/consul/consul.go Outdated Show resolved Hide resolved
@gqcn
Copy link
Member

gqcn commented Sep 18, 2023

@monchickey The CI failed it was missing CI service here: https://github.com/gogf/gf/blob/master/.github/workflows/gf.yml

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Patch coverage: 43.61% and project coverage change: -1.85% ⚠️

Comparison is base (7c9eefe) 79.24% compared to head (7f72744) 77.40%.

❗ Current head 7f72744 differs from pull request most recent head 9647f16. Consider uploading reports for the commit 9647f16 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
- Coverage   79.24%   77.40%   -1.85%     
==========================================
  Files         643      645       +2     
  Lines       52760    54145    +1385     
==========================================
+ Hits        41812    41911      +99     
- Misses       8867    10128    +1261     
- Partials     2081     2106      +25     
Flag Coverage Δ
go-1.18-386 77.47% <43.61%> (-1.81%) ⬇️
go-1.18-amd64 ?
go-1.19-386 77.35% <39.36%> (-1.79%) ⬇️
go-1.19-amd64 77.37% <43.61%> (-1.82%) ⬇️
go-1.20-386 ?
go-1.20-amd64 ?
go-1.21-386 77.46% <43.61%> (-1.83%) ⬇️
go-1.21-amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
contrib/config/consul/consul.go 43.61% <43.61%> (ø)

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

contrib/config/consul/consul_test.go Show resolved Hide resolved
.github/workflows/consul/docker-compose.yml Outdated Show resolved Hide resolved
.github/workflows/consul/docker-compose.yml Outdated Show resolved Hide resolved
@houseme houseme requested a review from gqcn September 25, 2023 02:33
@gqcn gqcn merged commit e673203 into gogf:master Sep 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants