Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve trace span generating for package gctx and http tracing content for package ghttp #2937

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

will0306
Copy link
Contributor

@will0306 will0306 commented Sep 5, 2023

1、项目底层上流调用链上报了WithCtx,此处干扰视线,影响界面显示,没法正常直观得看到展示的调用层
2、调用链上报的operation 是url, 这样会导致openration遍地繁衍,杂乱无章,如果想看具体请求业务日志,应当去日志系统查看

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 77.28% and project coverage change: -0.02% ⚠️

Comparison is base (74bf1b4) 79.15% compared to head (cf99c58) 79.14%.
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2937      +/-   ##
==========================================
- Coverage   79.15%   79.14%   -0.02%     
==========================================
  Files         638      639       +1     
  Lines       52570    52617      +47     
==========================================
+ Hits        41611    41642      +31     
- Misses       8892     8909      +17     
+ Partials     2067     2066       -1     
Flag Coverage Δ
go-1.18-386 79.16% <77.28%> (-0.03%) ⬇️
go-1.18-amd64 79.21% <77.28%> (+<0.01%) ⬆️
go-1.19-386 79.08% <77.28%> (-0.02%) ⬇️
go-1.19-amd64 79.03% <77.28%> (-0.07%) ⬇️
go-1.20-386 79.21% <77.28%> (-0.03%) ⬇️
go-1.20-amd64 79.13% <77.28%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
container/gmap/gmap_hash_str_any_map.go 98.20% <ø> (ø)
container/gset/gset_any_set.go 99.15% <ø> (ø)
contrib/nosql/redis/redis.go 83.90% <0.00%> (-5.12%) ⬇️
database/gdb/gdb.go 68.34% <ø> (ø)
database/gdb/gdb_result.go 36.00% <ø> (+3.85%) ⬆️
database/gredis/gredis_config.go 77.41% <ø> (ø)
internal/instance/instance.go 100.00% <ø> (ø)
os/gcache/gcache.go 96.77% <ø> (ø)
os/gtime/gtime.go 86.93% <ø> (ø)
text/gregex/gregex_cache.go 100.00% <ø> (ø)
... and 24 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

net/ghttp/ghttp_middleware_tracing.go Outdated Show resolved Hide resolved
@gqcn gqcn changed the title feat: 🎸 1、ctx初始化不上报span;2、middleware上报请求url改为path improve trace span generating for package gctx and http tracing content for package ghttp Sep 6, 2023
@houseme houseme requested a review from gqcn September 8, 2023 03:29
@gqcn gqcn merged commit 7391a4d into gogf:master Sep 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants