Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in:header tag cache for http request to enhance performance #2923

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Conversation

hailaz
Copy link
Member

@hailaz hailaz commented Sep 1, 2023

#2060
顺便修一个bug #2904

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Patch coverage: 76.80% and project coverage change: -0.02% ⚠️

Comparison is base (7c9eefe) 79.24% compared to head (a335555) 79.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2923      +/-   ##
==========================================
- Coverage   79.24%   79.23%   -0.02%     
==========================================
  Files         643      643              
  Lines       52760    52814      +54     
==========================================
+ Hits        41812    41848      +36     
- Misses       8867     8882      +15     
- Partials     2081     2084       +3     
Flag Coverage Δ
go-1.18-386 79.33% <76.80%> (+0.05%) ⬆️
go-1.18-amd64 79.33% <76.80%> (+0.03%) ⬆️
go-1.19-386 79.19% <76.80%> (+0.05%) ⬆️
go-1.19-amd64 79.19% <76.80%> (+<0.01%) ⬆️
go-1.20-386 79.31% <76.80%> (+0.03%) ⬆️
go-1.20-amd64 79.29% <76.80%> (+0.03%) ⬆️
go-1.21-386 79.26% <76.80%> (-0.03%) ⬇️
go-1.21-amd64 79.28% <76.80%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
net/ghttp/ghttp.go 100.00% <ø> (ø)
net/ghttp/ghttp_server_service_handler.go 63.42% <63.29%> (+0.16%) ⬆️
net/ghttp/ghttp_request_middleware.go 87.65% <100.00%> (+4.77%) ⬆️
net/ghttp/ghttp_request_param_request.go 91.75% <100.00%> (+0.58%) ⬆️
net/ghttp/ghttp_server_openapi.go 81.81% <100.00%> (ø)
os/gstructs/gstructs_field_tag.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hailaz hailaz added the wip label Sep 4, 2023
@gqcn gqcn changed the title 预处理标准路由的参数tag反射 add in:header tag support for http request Sep 4, 2023
@gqcn gqcn changed the title add in:header tag support for http request add in:header tag cache for http request to enhance performance Sep 4, 2023
@gqcn
Copy link
Member

gqcn commented Sep 4, 2023

@hailaz CI失败了,请查看一下呢。另外这提交的修改代码量有点多,能否把bug修复和改进分成两个pr方便review

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@hailaz CI failed, please check it out. In addition, the amount of modified code submitted here is a bit too much. Can you divide the bug repair and improvement into two pr for review.

@hailaz
Copy link
Member Author

hailaz commented Sep 5, 2023

@hailaz CI失败了,请查看一下呢。另外这提交的修改代码量有点多,能否把bug修复和改进分成两个pr方便review

@gqcn 先看#2931

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@hailaz CI failed, please check it out. In addition, the amount of modified code submitted here is a bit too much. Can you divide the bug repair and improvement into two pr for review.

@gqcn first look at #2931

@hailaz hailaz added done This issue is done, which may be release in next version. and removed wip labels Sep 5, 2023
net/ghttp/ghttp_server_service_handler.go Show resolved Hide resolved
net/ghttp/ghttp_server_service_handler.go Outdated Show resolved Hide resolved
net/ghttp/ghttp.go Outdated Show resolved Hide resolved
@gqcn gqcn removed the done This issue is done, which may be release in next version. label Sep 13, 2023
net/ghttp/ghttp_server_service_handler.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_server_service_handler.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_request_param_request.go Outdated Show resolved Hide resolved
net/ghttp/ghttp_request_middleware.go Outdated Show resolved Hide resolved
net/ghttp/ghttp.go Outdated Show resolved Hide resolved
net/ghttp/ghttp.go Outdated Show resolved Hide resolved
@gqcn gqcn merged commit 130191f into master Sep 25, 2023
24 checks passed
@gqcn gqcn deleted the fix/tags branch September 25, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants