Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve converter feature for package gconv #2869

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Aug 16, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Patch coverage: 66.32% and project coverage change: +0.04% 🎉

Comparison is base (932f8c4) 79.17% compared to head (26daf7c) 79.21%.
Report is 5 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2869      +/-   ##
==========================================
+ Coverage   79.17%   79.21%   +0.04%     
==========================================
  Files         634      634              
  Lines       52423    52573     +150     
==========================================
+ Hits        41506    41647     +141     
- Misses       8856     8867      +11     
+ Partials     2061     2059       -2     
Flag Coverage Δ
go-1.18-386 79.30% <66.32%> (+0.06%) ⬆️
go-1.18-amd64 79.29% <66.32%> (+0.09%) ⬆️
go-1.19-386 79.17% <66.32%> (+0.10%) ⬆️
go-1.19-amd64 79.20% <66.32%> (+0.08%) ⬆️
go-1.20-386 79.30% <66.32%> (+0.08%) ⬆️
go-1.20-amd64 79.29% <66.32%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
util/gconv/gconv_convert.go 91.63% <ø> (ø)
util/gconv/gconv_converter.go 62.61% <63.33%> (-9.70%) ⬇️
util/gconv/gconv_struct.go 82.77% <100.00%> (+0.14%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hailaz hailaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看代码是新增了一个注册类型转换函数功能,支持对自定义的类型转换,对吧?

Copy link
Contributor

@joy999 joy999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@gqcn
Copy link
Member Author

gqcn commented Aug 17, 2023

看代码是新增了一个注册类型转换函数功能,支持对自定义的类型转换,对吧?

yep

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Looking at the code, there is a new registration type conversion function function, which supports custom type conversion, right?

yep

@gqcn gqcn merged commit ed4d155 into master Aug 17, 2023
18 checks passed
@gqcn gqcn deleted the enhance/gconv-converter branch August 17, 2023 12:33
@gqcn gqcn restored the enhance/gconv-converter branch January 22, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants