Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve header printing in json format for package glog; add golang v1.18 support for ci workflow #2037

Merged
merged 15 commits into from
Jul 29, 2022

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Jul 29, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #2037 (2dcbfe6) into master (9df0a9d) will increase coverage by 0.00%.
The diff coverage is 72.41%.

@@           Coverage Diff           @@
##           master    #2037   +/-   ##
=======================================
  Coverage   76.52%   76.52%           
=======================================
  Files         517      517           
  Lines       46726    46727    +1     
=======================================
+ Hits        35755    35760    +5     
+ Misses       9000     8997    -3     
+ Partials     1971     1970    -1     
Flag Coverage Δ
go-1.15-386 76.46% <72.41%> (+0.03%) ⬆️
go-1.15-amd64 76.43% <72.41%> (+0.03%) ⬆️
go-1.16-386 76.43% <72.41%> (+0.01%) ⬆️
go-1.16-amd64 76.46% <72.41%> (+0.03%) ⬆️
go-1.17-386 76.46% <72.41%> (+<0.01%) ⬆️
go-1.17-amd64 76.48% <72.41%> (-0.01%) ⬇️
go-1.18-386 76.44% <72.41%> (?)
go-1.18-amd64 76.44% <72.41%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_request.go 84.73% <ø> (ø)
util/gutil/gutil.go 94.28% <ø> (ø)
os/glog/glog_logger.go 73.81% <71.42%> (-0.10%) ⬇️
os/glog/glog_logger_handler.go 91.42% <73.91%> (+0.25%) ⬆️
os/gcache/gcache_adapter_memory_lru.go 97.82% <0.00%> (+8.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df0a9d...2dcbfe6. Read the comment docs.

Copy link
Member

@houseme houseme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gqcn gqcn changed the title improve header printing in json format for package glog improve header printing in json format for package glog; add golang v1.18 support for ci workflow Jul 29, 2022
@gqcn gqcn merged commit f580b7a into master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants