-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5.2.0 release #326
Open
meetdhananifynd
wants to merge
23
commits into
master
Choose a base branch
from
v5.2.0-release
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V5.2.0 release #326
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8f0538e
mearge fix one
prashant-fynd ac4e722
ID:FPCO-30358;DONE:100;HOURS:38;fix with new react webpack config
prashant-fynd 714fc4a
Merge branch 'new-cli-release' into cdn-new-cli
prashant-fynd beb300b
ID:FPCO-30358;DONE:100;HOURS:38;fix vue init error
prashant-fynd 7287ce0
ID:FPCO-30358;DONE:100;HOURS:38;rolex removal
prashant-fynd 72c25ba
ID:FPCO-30358;DONE:100;HOURS:38;import file upload
prashant-fynd 0df1057
Merge branch 'master' into cdn-new-cli
prashant-fynd 1cd18a7
ID:FPCO-30358;DONE:100;HOURS:38;vue import file path change
prashant-fynd 8080c23
ID:FPCO-34269;DONE:100;HOURS:10;dev-prod saparate build
meetdhananifynd 7de2685
use CDN key from grindor completed API
ashokrdkr 45f08dc
remove version compatibility api usage
ashokrdkr 832237a
remove version compatibility messages
ashokrdkr 890a5e9
Merge branch 'master' into grindor-complete-cdn
karanrainafynd cc8c87f
Merge branch 'master' into deprecate-compatibility-usage
karanrainafynd fe7ab5a
Fix grindor cdn URL
karanrainafynd 99c37a9
Fix grindor cdn URL
karanrainafynd af67b10
align with master
karanrainafynd 6ce14b4
add some dummy content to file so it gets uploaded
karanrainafynd 1de114c
Merge branch 'master' of github.com:gofynd/fdk-cli
meetdhananifynd f0b0042
Merge remote-tracking branch 'origin/deprecate-compatibility-usage' i…
meetdhananifynd b8e60b5
Merge remote-tracking branch 'origin/grindor-complete-cdn' into v5.2.…
meetdhananifynd 35a84f2
Merge remote-tracking branch 'origin/cdn-new-cli' into v5.2.0-release
meetdhananifynd 9898fdd
version bump
meetdhananifynd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// ! DO NOT REMOVE | ||
// This file is used to get CDN base path |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why throwing error is needed when simply assignment of assetNormalizedBasePath is required?
Also code needs to be formatted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can omit
try-catch
altogether here, Doesn't seems it is required here.