Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: assert UUID satisfies the driver.Valuer and sql.Scanner interfaces #113

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

charlievieth
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7eb9dd3) compared to base (ebca088).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          448       448           
=========================================
  Hits           448       448           
Impacted Files Coverage Δ
sql.go 100.00% <ø> (ø)
uuid.go 100.00% <0.00%> (ø)
codec.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@17twenty
Copy link
Member

Related to #108 I assume?

@charlievieth
Copy link
Contributor Author

Related to #108 I assume?

Yes, should have made that clearer.

@cameracker
Copy link
Collaborator

I'll give some other folks a chance to comment but i'll merge within the next few days. Thank you very much @charlievieth !

@dylan-bourque
Copy link
Member

👍 from me

@cameracker cameracker merged commit 7b40032 into gofrs:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants