Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: merge some external middlewares to core #2453

Merged
merged 5 commits into from
May 10, 2023
Merged

♻️ refactor: merge some external middlewares to core #2453

merged 5 commits into from
May 10, 2023

Conversation

efectn
Copy link
Member

@efectn efectn commented May 8, 2023 •
edited
Loading

Description

This PR merges adaptor, helmet, keyauth, redirect, rewrite middlewares to reduce maintenance.

  • Fix linting issues.
  • Add descriptions of some middlewares.
  • Update README.

Type of change

  • Refactoring
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • New and existing unit tests pass locally with my changes

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@efectn efectn requested review from ReneWerner87 and gaby May 8, 2023 19:41
gaby
gaby requested changes May 8, 2023
View reviewed changes
middleware/keyauth/keyauth_test.go Show resolved Hide resolved
middleware/redirect/redirect_test.go Show resolved Hide resolved
middleware/rewrite/rewrite_test.go Show resolved Hide resolved
middleware/adaptor/adaptor.go Show resolved Hide resolved
gaby
gaby approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@gaby gaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReneWerner87
Copy link
Member

thank you, looks good at first glance, but still need to look more closely

will merge it on the weekend

@ReneWerner87
Copy link
Member

I will merge it and then look at it in the master, in case of errors we have to open follow-up PR's.

@ReneWerner87 ReneWerner87 merged commit c7c37d9 into master May 10, 2023
@efectn efectn deleted the add-external-middlewares branch May 10, 2023 06:08
leonklingele added a commit to leonklingele/helmet that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
981ca97 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/rewrite that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
5505d67 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/redirect that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
9512335 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/adaptor that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
22f85e4 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/keyauth that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
3a8f49e 
See gofiber/fiber#2453.
This was referenced May 15, 2023
Merged
Merged
Merged
Merged
Merged
leonklingele added a commit to leonklingele/adaptor that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
6f240ab 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/helmet that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
cd1f0b6 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/keyauth that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
068ffbc 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/redirect that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
db0a239 
See gofiber/fiber#2453.
leonklingele added a commit to leonklingele/rewrite that referenced this pull request May 15, 2023
@leonklingele
go: deprecate this module as now part of fiber core
5313379 
See gofiber/fiber#2453.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaby gaby gaby approved these changes

@ReneWerner87 ReneWerner87 Awaiting requested review from ReneWerner87

Assignees
No one assigned
Labels
🧹 Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efectn @ReneWerner87 @gaby