Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 v3 Feature: Make app.Test accept a time.Duration timeout #2269

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

leonklingele
Copy link
Member

Cases found by running semgrep with an empty .semgrepignore file

semgrep --lang=go -e '$O.Test($X, $Y)'

Description

Make app.Test accept a time.Duration timeout instead of an timeout specified in milliseconds.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - https://github.com/gofiber/docs for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Cases found by running semgrep with an empty .semgrepignore file

    semgrep --lang=go -e '$O.Test($X, $Y)'
@ReneWerner87
Copy link
Member

Thx

@ReneWerner87 ReneWerner87 merged commit 6334f2c into gofiber:v3-beta Dec 12, 2022
@efectn efectn added the v3 label Dec 12, 2022
@efectn efectn added this to the v3 milestone Dec 12, 2022
@leonklingele
Copy link
Member Author

leonklingele commented Mar 5, 2024

I see this not being part of v3 atm, even though this got merged. Why?!

@ReneWerner87
Copy link
Member

I see this not being part of v3 atm, even though this got merged. Why?!

sorry, i will look why this is the case

@ReneWerner87
Copy link
Member

unfortunately i have not found an explanation
normally beta-v3 is in main and main contains your commit, yet the code is not customized

I have updated the code
370cc8b

grivera64 pushed a commit to grivera64/fiber that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants