🚀 [Feature]: Cache-Control: no-cache

[marcmartin13]

Added noCache function for checking Cache-Control: no-cache in the request header

Description

If the request header contains Cache-Control: no-cache it will skip getting the cached entry and proceeds to cache the response.

Type of change

• New feature (non-breaking change which adds functionality)

Checklist:

• I have performed a self-review of my own code

[welcome]

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[ReneWerner87]

@marcmartin13 thanks for the work

can you tell me what is the difference of this function with the Next function? this can also be done with it or ?

thought rather we integrate the fixed without possible change of functionality

can you add more tests so we can make sure this functionality works and we don't have to manually test each time for minor adjustments

[marcmartin13]

@marcmartin13 thanks for the work

can you tell me what is the difference of this function with the Next function? this can also be done with it or ?

thought rather we integrate the fixed without possible change of functionality

can you add more tests so we can make sure this functionality works and we don't have to manually test each time for minor adjustments

Hi @ReneWerner87

1st:
noCache function allows clients to request the most up-to-date response. Technically it just skips getting the cached entry and proceeds to cache the response (always miss). Next function can do that too, BUT once the response is cached you will always get that cached entry until it expires (always hit). This will cause the ETag middleware to return 304 when using "If-None-Match" since it will just always return the cached entry instead of the updated ones.

2nd:
I've already tried it but it's not working as expected because the cache middleware goes like this.

1. check/get cached entry
2. Next function
3. cache response

It will always return the cached entry (not yet expired) before reaching the Next function.

3rd:
Test_Cache_WithCacheControlNoCacheRequestHeader
Test_Cache_WithETagAndCacheControlNoCacheRequestHeader

My workaround right now is to use skip middleware but I don't think it's a good practice.

I've updated all of my comments because I don't understand my English 🤣

Thanks!

[efectn]

Please update readme and create a PR for docs

[marcmartin13]

Please update readme and create a PR for docs

Hi @efectn, I'm sorry but where I can find it, and how to create PR for docs? Thank you

[efectn]

Please update readme and create a PR for docs

Hi @efectn, I'm sorry but where I can find it, and how to create PR for docs? Thank you

https://github.com/gofiber/docs/tree/master/api/middleware you can take a look here

[marcmartin13]

Hi @ReneWerner87 and @efectn

may I ask if is it ok to add one more feature?

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

[ReneWerner87]

not sure yet if we really should expose the RequestDirective method

[ReneWerner87]

Please update readme and create a PR for docs

• update readme and create a PR for docs

[marcmartin13]

I've changed it to a normal private function.

Question: is updating readme and docs necessary since it is just a private function?

thanks!

[efectn]

I've changed it to a normal private function.

Question: is updating readme and docs necessary since it is just a private function?

thanks!

No

[ReneWerner87]

I've changed it to a normal private function.

Question: is updating readme and docs necessary since it is just a private function?

thanks!

we could already describe the new behavior so that everyone knows when they use the middleware and don't have to look in the code, but maybe you already implicitly assume this behavior

[marcmartin13]

not sure yet if we really should expose the RequestDirective method

not sure yet if we really should expose the RequestDirective method

I've changed it to a normal private function.
Question: is updating readme and docs necessary since it is just a private function?
thanks!

we could already describe the new behavior so that everyone knows when they use the middleware and don't have to look in the code, but maybe you already implicitly assume this behavior

yep, you are right. but I don't know where to put the description of this function since readme and docs have only the config description.

[ReneWerner87]

then just start with the first descriptions

look at the other middlewares and copy the style or look where the description i

[marcmartin13]

then just start with the first descriptions

look at the other middlewares and copy the style or look where the description i

on it

[ReneWerner87]

https://github.com/gofiber/fiber/blob/master/middleware/cache/README.md?plain=1#L3
https://github.com/gofiber/docs/blob/master/api/middleware/cache.md?plain=1#L3

[marcmartin13]

@ReneWerner87 thanks for helping me

[ReneWerner87]

@ReneWerner87 thanks for helping me

thx for the contribution^^

[welcome]

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord