Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vehicle-monitoring should only be called if siriApiKey has been set #2

Open
aaronbrethorst opened this issue Jun 17, 2024 · 1 comment · May be fixed by #3
Open

vehicle-monitoring should only be called if siriApiKey has been set #2

aaronbrethorst opened this issue Jun 17, 2024 · 1 comment · May be fixed by #3

Comments

@aaronbrethorst
Copy link
Contributor

aaronbrethorst commented Jun 17, 2024 •
edited
Loading

Upon launching the web app, I'm seeing hundreds of failed requests to vehicle-monitoring, all of which come from VehicleInfo.tsx's function getBusInfo() or actions.ts's getActiveBuses()/getAllBuses(). These functions should only be called if siriApiKey has been set.

image
@aaronbrethorst aaronbrethorst changed the title getBusInfo should only get invoked if siriApiKey has been set vehicle-monitoring.json should only be called if siriApiKey has been set Jun 17, 2024
@aaronbrethorst aaronbrethorst changed the title vehicle-monitoring.json should only be called if siriApiKey has been set vehicle-monitoring should only be called if siriApiKey has been set Jun 17, 2024
aaronbrethorst added a commit to aaronbrethorst/onebusaway-react-webapp that referenced this issue Jun 18, 2024
@aaronbrethorst
Only call siri/vehicle-monitoring if the app has siriApiKey set
e5dd2d6 
Fixes goeuropa#2
@aaronbrethorst aaronbrethorst linked a pull request Jun 18, 2024 that will close this issue
Open
@Michal-Radomski
Copy link
Collaborator

This is my response: aaronbrethorst@e5dd2d6#commitcomment-143300421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@aaronbrethorst @Michal-Radomski