Merge pull request #8 from goedemiddag/attestation-rewrite

Clear resident key to prevent client resident encoding
goedemiddag · Nov 3, 2023 · c31dba5 · c31dba5
2 parents fe4d8d6 + f74a49e
commit c31dba5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -29,6 +29,7 @@
     },
     "require-dev": {
         "laravel/framework": "^10",
+        "laravel/tinker": "^2.8",
         "phpunit/phpunit": "^9.5.2"
     },
     "autoload": {

diff --git a/src/LarapassServiceProvider.php b/src/LarapassServiceProvider.php
@@ -196,9 +196,7 @@ static function ($app) {
                     $config->get('larapass.attachment')
                 );
 
-                if ($userless = $config->get('larapass.userless')) {
-                    $selection->setResidentKey($userless);
-                }
+                $selection->clearResidentKey();
 
                 return $selection;
             }

diff --git a/src/WebAuthn/AuthenticatorSelectionCriteria.php b/src/WebAuthn/AuthenticatorSelectionCriteria.php
@@ -40,6 +40,10 @@ public function getResidentKey(): ?string
         return $this->residentKey;
     }
 
+    public function clearResidentKey(): void
+    {
+        $this->residentKey = null;
+    }
     /**
      * @return array<string, mixed>
      */