This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Change ckb decimal to 18 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flouse
approved these changes
May 6, 2022
keroro520
approved these changes
May 6, 2022
Flouse
approved these changes
May 6, 2022
value => u256, sudt_transfer.amount => u256, sudt_transfer.fee.amount => u128
zeroqn
approved these changes
May 6, 2022
RetricSu
reviewed
May 6, 2022
| @@ -30,6 +30,10 @@ jobs: | |||
| - run: yarn run build | |||
| - run: yarn workspace @godwoken-web3/api-server run test tests/db/helpers.test.ts | |||
| - run: yarn workspace @godwoken-web3/api-server run test tests/utils/erc20.test.ts | |||
| - run: yarn workspace @godwoken-web3/api-server run test tests/base/types/uint32.test.ts | |||
There was a problem hiding this comment.
Suggested change
| - run: yarn workspace @godwoken-web3/api-server run test tests/base/types/uint32.test.ts | |
| - run: yarn workspace @godwoken-web3/api-server run test tests/base/types |
the four tests can be simplified to one line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
godwoken
godwoken-scripts
godowken-polyjuice
godowken-tests