Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable rounded window corners on Windows #96575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pkdawson
Copy link
Contributor

@pkdawson pkdawson commented Sep 4, 2024

I noticed when reading the latest Dolphin progress report that it's actually possible to disable the rounded corners in Windows 11.

I feel like this is a desirable change for games in general, as it actually shows everything you render instead of hiding the bottom corners, which is particularly annoying when taking screenshots.

I suppose the argument against would be that it's inconsistent with the Windows 11 default, so non-game applications might look slightly odd to a user.

@pkdawson pkdawson requested a review from a team as a code owner September 4, 2024 21:20
Copy link

@frkntlr frkntlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears without rounded corners in Windows 10.

Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Dolphin only applies the sharp corners for the game window; all other windows still retain the default, rounded style:
24-09-05 07-39-51 explorer

platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
@pkdawson
Copy link
Contributor Author

pkdawson commented Sep 5, 2024

Yeah makes sense, since the editor should always have empty space in the bottom few pixels, the corners don't really matter.

@Hilderin
Copy link
Contributor

Hilderin commented Sep 7, 2024

That will change a default Windows behavior. I guess for games it's great but for applications created with Godot, they probably prefers rounded corners. I think a new flag to deactivate the rounded corner should be a preferred and move flexible way. With a new flag, the condition on specific Engine window in DisplayServerWindows could be replaced by this new flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants