[C#] Fix building with deprecated=no
#96570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
deprecated=no
akien-mga
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Makes sense to me. I'm not too familiar with C# buildsystem stuff though so I'll let @raulsntos double check.
Drako
force-pushed
the
fix-godotsharp-build-failing-with-no-deprecated
branch
from
107aad7
to
2c55a23
Compare
|
I don't see any merge commits ;) |
Drako
force-pushed
the
fix-godotsharp-build-failing-with-no-deprecated
branch
from
2c55a23
to
aed2209
Compare
raulsntos
requested changes
Sep 5, 2024
Drako
force-pushed
the
fix-godotsharp-build-failing-with-no-deprecated
branch
from
aed2209
to
e9762b3
Compare
|
Makes sense to me. I also considered excluding Compat.cs first, but wasn't sure, if there was stuff in it which is still needed. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes GH-84426.
I added the option
--no-deprecatedtobuild_assemblies.py, which needs to be used, if the editor was built withdeprecated=no module_mono_enabled=yes.This conditionally disables code in
Compat.cswhich references deprecated classes or functions.